Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/frontend npm bump #1031

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

Holovin
Copy link
Contributor

@Holovin Holovin commented Jan 4, 2023

  1. Сделал форк (vue-map → vue-map-ho), залил его с фиксами других людей на npm

  2. Поправил сборку на фронте (пока не уверен что оно ок, но старый фронт тоже почему-то у меня не собирался без этих правил)

  3. Версии в package.json бампнул повыше (vue-loader есть 17ый вместо 15ого, но там тоже какой-то баг — vue-loader 17 compatibility with vue 2 vuejs/vue-loader#1919 + feat: add postcss 8 support vuejs/component-compiler-utils#121)

@Holovin Holovin requested a review from vas3k as a code owner January 4, 2023 15:34
@vas3k
Copy link
Owner

vas3k commented Jan 4, 2023

vue-loader есть 17ый вместо 15ого, но там тоже какой-то баг

Ору. Фронтенд это весело!

Copy link
Owner

@vas3k vas3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажись работает

@vas3k vas3k merged commit c811429 into vas3k:master Jan 4, 2023
@Holovin Holovin deleted the bugfix/frontend-npm-bump branch November 5, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants