Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update dependencies #2748

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

reneleonhardt
Copy link
Contributor

@reneleonhardt reneleonhardt commented May 30, 2023

Updated everything except JUnit.
If this pull request is accepted, a separate one will be submitted for JUnit 5 with lots of small code changes.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.78%. Comparing base (e43e44b) to head (94adfb9).
Report is 46 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2748      +/-   ##
============================================
+ Coverage     92.74%   92.78%   +0.03%     
- Complexity     5247     5262      +15     
============================================
  Files            89       89              
  Lines         12538    12535       -3     
  Branches       1604     1595       -9     
============================================
+ Hits          11628    11630       +2     
+ Misses          721      718       -3     
+ Partials        189      187       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pivovarit
Copy link
Member

Looks good to me, thanks :)

@pivovarit pivovarit enabled auto-merge (squash) August 22, 2024 08:52
@pivovarit pivovarit merged commit 7625eb1 into vavr-io:master Aug 22, 2024
4 checks passed
@reneleonhardt
Copy link
Contributor Author

You're welcome, thanks for merging :)
Didn't know there was a new maintainer, cool! Do you want to upgrade to JUnit Jupiter? JUnit 4 is 3 years old and EOL...

@pivovarit
Copy link
Member

If you feel like it, then go and do it :) stretch goal: update https://github.com/vavr-io/vavr/tree/version/0.10.5 as well

@reneleonhardt
Copy link
Contributor Author

stretch goal: update https://github.com/vavr-io/vavr/tree/version/0.10.5 as well

I don't understand, 0.10.5 and 0.11.0 are extremely different from master, for example Maven instead of Gradle, let alone licenses, copyrights, docs, imports, code and tests.
What kind of branches are they? What is there to update?
Every release should be tagged from the default branch (master), or a child branch which just adds commits to the same base.

@pivovarit
Copy link
Member

Those branches are not alternative realities, but... a journey to the past. 0.10.5 is a child branch off 0.10.4 from 2021.

Since that time, master went through a major overhaul due to 1.0.0 release preparations, but at the same time, new 0.x bugfixes needed to be shipped. I backported multiple bugfixes that happened during the last couple of years and will release it as 0.10.5 first. Then, some of the features will land in 0.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants