Removed setting initial value for enum type #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: Bridge
kestarumper
approved these changes
Jun 21, 2024
piotrpospiech
force-pushed
the
zod-enum-initial-value
branch
from
b493932
to
d41421a
Compare
github-actions
bot
added
Area: Core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 95.46% 95.53% +0.06%
==========================================
Files 175 175
Lines 2869 2867 -2
Branches 775 774 -1
==========================================
Hits 2739 2739
Misses 59 59
+ Partials 71 69 -2 ☔ View full report in Codecov by Sentry. |
zendranm
approved these changes
Oct 25, 2024
piotrpospiech
force-pushed
the
zod-enum-initial-value
branch
from
e90a4da
to
0bc096e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SelectField). This is the same behavior as we have for example in theSimpleSchema2BridgeBefore
After
Future work
SelectFieldtests will be changed (MigratedSelectFieldtests to @testing-library/react #1351), I will do it after the PR merge. For this reason, I open this as a draft.