Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Multilingual support #45

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

mvietri
Copy link
Collaborator

@mvietri mvietri commented May 28, 2024

Add new codes for lang parameter. See https://openweathermap.org/current#multi for more details.

Closes #4

@mvietri
Copy link
Collaborator Author

mvietri commented May 28, 2024

Please, squash this PR. Using the built in editor here was kind of nightmare with spaces and tabs.

@vb2ae vb2ae self-assigned this May 29, 2024
@vb2ae vb2ae added this to the In Review milestone May 29, 2024
Copy link
Owner

@vb2ae vb2ae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you did looks good. Could you update the Version, FileVersion, PackageVersion, and assembly version to 2.1.0 in the OpenWeatherMap.Standard project?

@vb2ae vb2ae assigned mvietri and unassigned vb2ae May 29, 2024
@mvietri
Copy link
Collaborator Author

mvietri commented May 30, 2024

The code you did looks good. Could you update the Version, FileVersion, PackageVersion, and assembly version to 2.1.0 in the OpenWeatherMap.Standard project?

Sure. Do you want that changes in this PR or create another one just for the release?

@vb2ae vb2ae merged commit 4e67682 into vb2ae:master May 30, 2024
3 checks passed
@vb2ae
Copy link
Owner

vb2ae commented May 31, 2024

Sorry I created it in another pr. Thanks for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Multilingual support
2 participants