Skip to content

Commit

Permalink
sagemathgh-39003: CI Fix: Do not upload logs artifact for the default…
Browse files Browse the repository at this point in the history
… job in CI Linux

    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

fixes the failure seen in https://github.com/sagemath/sage/actions/runs/
11869791506/job/33080484685

The cause is duplicate uploading of artifacts of the same name.

Test:
https://github.com/kwankyu/sage/actions/runs/11906298470/job/33178163324

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39003
Reported by: Kwankyu Lee
Reviewer(s):
  • Loading branch information
Release Manager committed Nov 27, 2024
2 parents 4076bce + 8377403 commit cb6ca56
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
tox_packages_factors: >-
["standard"]
docker_push_repository: ghcr.io/${{ github.repository }}/
logs_artifact: false

# All platforms. This duplicates the default platform, but why not,
# it makes it more robust regarding random timeouts.
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ on:
description: 'Elapsed time (seconds) at which to kill the build'
default: 20000
type: number
logs_artifact:
default: true
type: boolean
#
# Publishing to GitHub Packages
#
Expand Down Expand Up @@ -260,11 +263,12 @@ jobs:
cp -r .tox/$TOX_ENV/* "artifacts/$LOGS_ARTIFACT_NAME"
rm -rf "artifacts/$LOGS_ARTIFACT_NAME"/{bin,lib,pyvenv.cfg}
if: always()
- uses: actions/upload-artifact@v4
- name: Upload logs artifact
uses: actions/upload-artifact@v4
with:
path: artifacts
name: ${{ env.LOGS_ARTIFACT_NAME }}
if: always()
if: always() && inputs.logs_artifact
- name: Print out logs for immediate inspection
# and markup the output with GitHub Actions logging commands
run: |
Expand Down

0 comments on commit cb6ca56

Please sign in to comment.