json validation strict with py

.github/ignore_json.py

@@ -0,0 +1 @@
+ignore = [ "./github.json", "./vcmi-1.2.json", "./vcmi-1.3.json" ]

.github/update_size.py

@@ -4,15 +4,15 @@
 import sys
 import urllib.request
 
-ignore = [ "./github.json", "./vcmi-1.2.json", "./vcmi-1.3.json" ]
+from ignore_json import ignore
 
 for filename in glob.glob(os.path.join('.', '*.json')):
     if filename not in ignore:
         print(f"Opening: {filename}")
         filecontent = open(filename, "r").read()
         modlist = json.loads(filecontent)
         for mod, data in modlist.items():
-            url = data["download"]
+            url = data["download"].replace(" ", "%20")
             print(f"Download {mod}: {url}")
             try:
                 response = urllib.request.urlopen(url)

.github/validate_json.py

@@ -0,0 +1,23 @@
+import json
+import glob
+import os
+import sys
+import urllib.request
+
+from ignore_json import ignore
+
+error = False
+
+for filename in glob.glob(os.path.join('.', '*.json')):
+    if filename not in ignore:
+        print(f"Opening: {filename}")
+        filecontent = open(filename, "r").read()
+
+        try:
+            json.loads(filecontent)
+        except Exception as err:
+            print("Error: " + str(err))
+            sys.exit(os.EX_SOFTWARE)
+
+print("Everything is ok!")
+sys.exit(os.EX_OK)

.github/validate_mod_json.py

@@ -4,7 +4,7 @@
 import sys
 import urllib.request
 
-ignore = [ "./github.json", "./vcmi-1.2.json", "./vcmi-1.3.json" ]
+from ignore_json import ignore
 
 error = False
 
@@ -14,7 +14,7 @@
         filecontent = open(filename, "r").read()
         modlist = json.loads(filecontent)
         for mod, data in modlist.items():
-            url = data["mod"]
+            url = data["mod"].replace(" ", "%20")
             print(f"Download {mod}: {url}")
             try:
                 response = urllib.request.urlopen(url)
@@ -28,7 +28,7 @@
                 json.loads(filecontent)
             except Exception as err:
                 error = True
-                print("Error: " + err)
+                print("Error: " + str(err))
                 continue
 if error:
     sys.exit(os.EX_SOFTWARE)

.github/workflows/main.yml

@@ -12,16 +12,18 @@ on:
   workflow_dispatch:
 
 jobs:
-  check_json:
+  validate_json:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        shell: bash
     steps:
       - uses: actions/checkout@v3
-      - name: json-syntax-check
-        uses: limitusus/json-syntax-check@v2
-        with:
-          pattern: "\\.json$"
+      - name: Validate json
+        run: |
+          python3 .github/validate_json.py
   validate_mod_json:
-    needs: check_json
+    needs: validate_json
     runs-on: ubuntu-latest
     defaults:
       run:
@@ -32,7 +34,7 @@ jobs:
         run: |
           python3 .github/validate_mod_json.py
   update_size:
-    needs: check_json
+    needs: validate_json
     runs-on: ubuntu-latest
     defaults:
       run: