Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to go-module #10

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Convert to go-module #10

merged 6 commits into from
Aug 14, 2024

Conversation

libotony
Copy link
Member

No description provided.

otherview
otherview previously approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just double checking some comments are intentional

eth/downloader/downloader_test.go Show resolved Hide resolved
metrics/sample_test.go Outdated Show resolved Hide resolved
mobile/android_test.go Show resolved Hide resolved
@libotony libotony merged commit bf60891 into thor-upstream Aug 14, 2024
3 checks passed
@libotony libotony deleted the go-module-1 branch August 14, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otherview otherview otherview approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libotony @otherview