Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VeTools Milestone 2 and 3 Submission #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hazelcaus
Copy link
Contributor

Milestone Submission

All deliverables completed per agreement. Additionally, VeTools v1.0.7 is live on the VSCode Marketplace. Source code: https://github.com/hazelcaus/vetools

Additionally because of the delay between our previous milestone deliverable and now, we have decided to complete development of all milestones.

Further: the RPC node urls for Vechain network are incorrect and I've been unable to find proper EVM-compatible RPC Urls. As such, these are the only pending requirements. Would just need to make quick updates to these urls and release an update.

@NecoSherry NecoSherry added the milestone delivery Submission of completed milestones label Jul 24, 2024
@NecoSherry NecoSherry requested a review from libotony July 24, 2024 05:27
@hazelcaus
Copy link
Contributor Author

@libotony @NecoSherry

@libotony
Copy link
Member

libotony commented Aug 14, 2024

Further: the RPC node urls for Vechain network are incorrect and I've been unable to find proper EVM-compatible RPC Urls. As such, these are the only pending requirements. Would just need to make quick updates to these urls and release an update.

VeChain is compatible with ethereum ecosystem at the EVM level, but not at the API level. In another word, VeChain doesn't have a ethereum like RPC interface, it has its own defined RESTful API.

Here is some useful links of tools use ethereum sdks in VeChain:

  1. https://github.com/vechain/web3-providers-connex
  2. https://github.com/vechain/hardhat-plugins
  3. https://github.com/vechain/vechain-sdk-js

@hazelcaus

@libotony
Copy link
Member

I started with a fresh new workspace as instructed in the extension documentation. I have encountered the following error when compiling the contracts.

vetools>>> 
> [email protected] compile
> hardhat compile

vetools>>> Error HH1: You are not inside a Hardhat project.
vetools>>> For more info go to https://hardhat.org/HH1 or run Hardhat with --show-stack-traces
vetools>>> 
vetools>>> Finished running command

@hazelcaus
Copy link
Contributor Author

I started with a fresh new workspace as instructed in the extension documentation. I have encountered the following error when compiling the contracts.

vetools>>> 
> [email protected] compile
> hardhat compile

vetools>>> Error HH1: You are not inside a Hardhat project.
vetools>>> For more info go to https://hardhat.org/HH1 or run Hardhat with --show-stack-traces
vetools>>> 
vetools>>> Finished running command

@libotony I'm not able to reproduce your issue. Please see this video of me trying to achieve the same thing. I'm able to flawlessly create a new project and compile contracts successfully.

If it might help, please try creating a separate folder prior to selecting VeTools: New Project and then selecting that folder during the command execution

@hazelcaus
Copy link
Contributor Author

Here's an updated link to the video @libotony

@libotony
Copy link
Member

Here's an updated link to the video @libotony

Thanks for the video, the project I have created using [email protected] seems not having the file hardhat.config.ts

@hazelcaus
Copy link
Contributor Author

Thank you for confirming @libotony. It turns out that VSCode didn't package the typescript files within the resources folder. As a result, the key files (including hardhat.config.ts) was missing. Should be fixed now in v1.0.9.

@hazelcaus
Copy link
Contributor Author

@libotony were you able to get it to work?

@libotony
Copy link
Member

Thank you for the update, I have tried the new version v1.0.9. Compile contract is working, but I have still have some issue during deploy:

  • LocalNode seems to be a ganache instance, it has some difference from vechain's instance.
  • Deploy to TestNet has an error hardhat.config.ts not found, after renaming the filename, it is telling H0061: Script scripts/deploy.ts doesn't exist
  • Regarding the delivery files, please put milestones separately.

@hazelcaus
Copy link
Contributor Author

thanks @libotony. We have fixed the deploy.ts issue -- there was an unpatched commit pending we didn't notice priorhand.

re: delivery files, we have already completed both milestones 2 and 3 and the PR reflects it as so. Imo, this would be better to parse and process and wrap up this grant proposal.

re: localNode is a ganache instance for testing because I wasn't able to get connex api to work via hardhat for some reason. Is there a technical forum/POC I can reach out to to fix this? I'll shortly describe the issue as a followup

@libotony
Copy link
Member

re: delivery files, we have already completed both milestones 2 and 3 and the PR reflects it as so. Imo, this would be better to parse and process and wrap up this grant proposal.

We don't mind if you deliver 2 and 3 together, we suggest the milestone to be put into two different files as the process was described here https://github.com/vechain/grant-program/tree/master/milestone-delivery#milestone-delivery-process

@libotony
Copy link
Member

re: localNode is a ganache instance for testing because I wasn't able to get connex api to work via hardhat for some reason. Is there a technical forum/POC I can reach out to to fix this? I'll shortly describe the issue as a followup

This might be an issue related to this comment:

VeChain is compatible with ethereum ecosystem at the EVM level, but not at the API level. In another word, VeChain doesn't have a ethereum like RPC interface, it has its own defined RESTful API.
Here is some useful links of tools use ethereum sdks in VeChain:
https://github.com/vechain/web3-providers-connex
https://github.com/vechain/hardhat-plugins
https://github.com/vechain/vechain-sdk-js

@hazelcaus
Copy link
Contributor Author

hazelcaus commented Sep 25, 2024

Thanks @libotony. Will do so (separation of milestone delivery shortly).

wrt to running a Thor Solo node, I'm getting the following error (I have built Thor from source via the build instructions):

Screenshot

Is there a technical forum/POC I can reach out to to fix this?

Also: is there any resource from which I can download pre-built Thor nodes for various architectures? Ideally, we want to abstract this away as much as possible from the user, but if it's unavoidable, we can have the user build the Solo node async and then we can reference the binary within the extension

@libotony
Copy link
Member

Thanks @libotony. Will do so (separation of milestone delivery shortly).

wrt to running a Thor Solo node, I'm getting the following error (I have built Thor from source via the build instructions):

Screenshot

Is there a technical forum/POC I can reach out to to fix this?

Also: is there any resource from which I can download pre-built Thor nodes for various architectures? Ideally, we want to abstract this away as much as possible from the user, but if it's unavoidable, we can have the user build the Solo node async and then we can reference the binary within the extension

Screenshot 2024-09-30 at 15 44 24

With the same parameter, I can successfully launch the solo instance.

Also: is there any resource from which I can download pre-built Thor nodes for various architectures?

Sorry, currently we are not publishing binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone delivery Submission of completed milestones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants