-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Ratverse Ascension collection into registry #21
Conversation
@0xyzid looks mostly good, except can you check the tokenLink? Its goal is have link to each token on the entry, for example a deep link to a single token on World of V of BlackVeMarket. Right now it links to the example for VeChainStats |
update tokenLink
update tokenLink
Hi,
TokenLink updated with World of V link only.
Please check if it is correct.
…On Wed, 9 Oct 2024 at 12:56 AM, Mario Micklisch ***@***.***> wrote:
@0xyzid <https://github.com/0xyzid> looks mostly good, except can you
check the tokenLink? Its goal is have link to each token on the entry, for
example a deep link to a single token on World of V of BlackVeMarket. Right
now it links to the example for VeChainStats
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6FKHGL24S2KAYMUZGVQHNDZ2QFCFAVCNFSM6AAAAABPSV6TU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGM4DAMBRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@0xyzid I believe I believe the TestNet address is incorrect: https://explore-testnet.vechain.org/accounts/0x1b60b8f4b83d146c051126873b9207247f7676ca/ has no contract deployed on it, is that correct? |
sorry for the slow reply, I have updated the PR.
[image: image.png]
…On Wed, Oct 9, 2024 at 1:23 AM Mario Micklisch ***@***.***> wrote:
@0xyzid <https://github.com/0xyzid> I believe
https://worldofv.art/token/0x1b60b8f4b83d146c051126873b9207247f7676ca/{{tokenId}}
would be the correct link for each token on WoV. The {{tokenId}} is
replaced with the actual token id, like this:
https://worldofv.art/token/0x1b60b8f4b83d146c051126873b9207247f7676ca/957
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6FKHGNI6BNR7ZJ6IRIWXC3Z2QIHXAVCNFSM6AAAAABPSV6TU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGQZDOOBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
the tokenLink is now hard coded and all tokens would link to 957 – can you make it dynamic like |
it has been updated.
[image: image.png]
…On Wed, Oct 9, 2024 at 2:22 AM Mario Micklisch ***@***.***> wrote:
sorry for the slow reply, I have updated the PR.
the tokenLink is now hard coded and all tokens would link to 957 – can you
make it dynamic like
https://worldofv.art/token/0x1b60b8f4b83d146c051126873b9207247f7676ca/{{tokenId}}
?
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6FKHGPVGT7HI3GPU4IWJP3Z2QPIBAVCNFSM6AAAAABPSV6TU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGUZTINRYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@0xyzid the checks failed, because the folder is not all lower case, can you make the address lower case?
… because you might encounter issues with your local filesystem, you might need to do this in two steps:
because some filesystems might not detect the case changes |
can you help me navigate the rename section, i think i cannot find how to
rename the folder
…On Wed, Oct 9, 2024 at 2:31 AM Mario Micklisch ***@***.***> wrote:
@0xyzid <https://github.com/0xyzid> the checks failed, because the folder
is not all lower case, can you make the address lower case?
0x1b60b8f4b83d146c051126873b9207247f7676ca
… because you might encounter issues with your local filesystem, you might
need to do this in two steps:
- rename to something totally different like:
_0x1b60b8f4b83d146c051126873b9207247f7676c
- commit
- rename to 0x1b60b8f4b83d146c051126873b9207247f7676ca
- commit
because some filesystems might not detect the case changes
—
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6FKHGJ7EE2UMCMQE26TNS3Z2QQHPAVCNFSM6AAAAABPSV6TU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGU2TAMBTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
[image: image.png]
i have updated the folder name. can you confirm if thi is correct?
…On Wed, Oct 9, 2024 at 2:41 AM Yazid ***@***.***> wrote:
can you help me navigate the rename section, i think i cannot find how to
rename the folder
On Wed, Oct 9, 2024 at 2:31 AM Mario Micklisch ***@***.***>
wrote:
> @0xyzid <https://github.com/0xyzid> the checks failed, because the
> folder is not all lower case, can you make the address lower case?
>
> 0x1b60b8f4b83d146c051126873b9207247f7676ca
>
> … because you might encounter issues with your local filesystem, you
> might need to do this in two steps:
>
> - rename to something totally different like:
> _0x1b60b8f4b83d146c051126873b9207247f7676c
> - commit
> - rename to 0x1b60b8f4b83d146c051126873b9207247f7676ca
> - commit
>
> because some filesystems might not detect the case changes
>
> —
> Reply to this email directly, view it on GitHub
> <#21 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A6FKHGJ7EE2UMCMQE26TNS3Z2QQHPAVCNFSM6AAAAABPSV6TU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGU2TAMBTGA>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
@0xyzid Sorry to have two more feedbacks: I believe you have a typo in your
should it be |
update line 5
update line 2
apologies on the error, i have updated as per feedback |
@libotony this looks good to me now, can you have another look? |
Looks good to me! |
Adding Ratverse Ascension collection into registry