Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v1 of the healthcheck and create github files for open source #1

Merged
merged 37 commits into from
Nov 2, 2023

Conversation

kgapos
Copy link
Member

@kgapos kgapos commented Oct 25, 2023

No description provided.

The pull request section in the CONTRIBUTING.md file has been updated to provide clearer instructions on how to submit a pull request. The new section includes step-by-step guidelines for forking the repository, creating a new branch, making changes, and opening a pull request against the main branch of the original repository. Additionally, a tip has been added to encourage users to follow git guidelines when writing commit messages.
@kgapos kgapos requested a review from a team October 25, 2023 14:38
@kgapos kgapos self-assigned this Oct 25, 2023
- Rename the file `gitleaks.yml` to `build.yml` for clarity.
- Update the workflow name from "gitleaks" to "Build".
- Modify the event triggers to include pull request events of types: opened, synchronize, reopened.
- Add a new job named "sonarcloud" for SonarCloud analysis.
- Configure SonarCloud steps to checkout code and perform the scan.
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@fabiorigam fabiorigam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in the src folder has no comments. We need to add comments to make the code clearer. I can add them, let me know :)

.github/README.md Outdated Show resolved Hide resolved
@kgapos
Copy link
Member Author

kgapos commented Nov 2, 2023

The code in the src folder has no comments. We need to add comments to make the code clearer. I can add them, let me know :)

Clean, readable code is usually enough to convey the intention. Failing that, comments are welcome. We also don't have any unit tests, but there's not much business logic here to be tested. Still, I had to relax the SonarCloud quality gate in order to accept a 0% unit test code coverage. Contributions in comments and tests are welcome anytime @fabiorigam, thank you in advance!

fabiorigam
fabiorigam previously approved these changes Nov 2, 2023
Copy link

sonarcloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

.github/CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@kgapos kgapos merged commit 654aa85 into main Nov 2, 2023
5 checks passed
@kgapos kgapos deleted the migrate-repo branch November 2, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants