Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx pool tests #636

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Tx pool tests #636

merged 8 commits into from
Jan 4, 2024

Conversation

MakisChristou
Copy link
Member

@libotony It was easier for me to create a new PR from scratch. I added your suggestions refactoring the NewDevnet function to take a timestamp argument instead of duplicating it. I also used the CreateTemp function in our test cases as you suggested. Code coverage is above 80% in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (869e9c5) 53.89% compared to head (1b2c195) 54.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   53.89%   54.73%   +0.83%     
==========================================
  Files         179      179              
  Lines       20665    20665              
==========================================
+ Hits        11138    11311     +173     
+ Misses       8703     8522     -181     
- Partials      824      832       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

txpool/tx_pool_test.go Outdated Show resolved Hide resolved
txpool/tx_pool_test.go Outdated Show resolved Hide resolved
txpool/blocklist_test.go Outdated Show resolved Hide resolved
@MakisChristou
Copy link
Member Author

By the way regarding the empty lines its probably cause by go fmt since its running every time I save on VS Code

@libotony
Copy link
Member

libotony commented Jan 3, 2024

By the way regarding the empty lines its probably cause by go fmt since its running every time I save on VS Code

I am also using vscode plus go language plugin, it does not add new lines of every new function but accepts one empty line.

@libotony
Copy link
Member

libotony commented Jan 3, 2024

BTW, the tests are failing since math/big is missing in txpool_test.go

@libotony libotony merged commit ef71fc0 into vechain:master Jan 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants