Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack notification #667

Merged
merged 2 commits into from
Feb 4, 2024
Merged

slack notification #667

merged 2 commits into from
Feb 4, 2024

Conversation

claytonneal
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

When unit tests fail on main branch send slack notification to team
Also adjusted the workflow to only run matrix job of unit tests on PR and push to main

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Sample request to slack channel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@claytonneal claytonneal requested a review from a team as a code owner January 31, 2024 18:39
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39ecf84) 57.40% compared to head (d3e493a) 51.98%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
- Coverage   57.40%   51.98%   -5.43%     
==========================================
  Files         179      156      -23     
  Lines       20678    17218    -3460     
==========================================
- Hits        11870     8950    -2920     
+ Misses       7922     7445     -477     
+ Partials      886      823      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@libotony libotony merged commit f77ab7f into master Feb 4, 2024
10 checks passed
@libotony libotony deleted the chore/slack-notification branch February 4, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants