cmd: add genesis flag to solo, allow specifying a custom genesis file…

[libotony]

… to solo

Description

This PR added a new flag --genesis to solo, allowing specifying a custom genesis file for starting a solo instance. If not, the default devnet genesis will be applied.

If there is a custom genesis applied to solo, built-in dev accounts will not be funded and the mnemonic words will not be displayed.

Builtin Contract Authority's state will be ignored, solo will use a default master key proposing blocks.

Fixes vechain/protocol-board-repo#158

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Start with thor solo --genesis <file-to-genesis.json> observe the log, test with API

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• New and existing E2E tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have not added any vulnerable dependencies to my code

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (e8a40c0) to head (14fafb1).
Report is 3 commits behind head on master.

❗ Current head 14fafb1 differs from pull request most recent head 1bb1d81. Consider uploading reports for the commit 1bb1d81 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
+ Coverage   57.24%   57.26%   +0.02%     
==========================================
  Files         156      156              
  Lines       17205    17218      +13     
==========================================
+ Hits         9849     9860      +11     
- Misses       6392     6394       +2     
  Partials      964      964              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[darrenvechain]

Hey @libotony I noticed we already have the --network flag to specify a genesis file for custom nets, should we re-use this flag?

[libotony]

Hey @libotony I noticed we already have the --network flag to specify a genesis file for custom nets, should we re-use this flag?

It is a bit different, --network includes mainnet/testnet, I think that will make devs confusion, also the word network is not proper for describing the feature for solo.