Skip to content

Commit

Permalink
feat: support shareProcessNamespace is pod.spec (#326)
Browse files Browse the repository at this point in the history
* feat: support shareProcessNamespace is pod.spec

* extraObjects fix lint (#325)

fix lint

* chore: add `shareProcessNamespace` to README.md

Additionally, move the `shareProcessNamespaces` in the `_pod.tpl`,
before `dnsPolicy`, to keep dns values together in the template.

---------

Co-authored-by: Andres Perez <[email protected]>
Co-authored-by: Roman Rinatovich <[email protected]>
  • Loading branch information
3 people authored Sep 11, 2023
1 parent c258d3d commit f9e8f0e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/vector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ helm install --name <RELEASE_NAME> \
| serviceAccount.create | bool | `true` | If true, create a ServiceAccount for Vector. |
| serviceAccount.name | string | `nil` | The name of the ServiceAccount to use. If not set and serviceAccount.create is true, a name is generated using the fullname template. |
| serviceHeadless.enabled | bool | `true` | If true, create and provide a Headless Service resource for Vector. |
| shareProcessNamespace | bool | `false` | Specify the [shareProcessNamespace](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/) options for Vector Pods. |
| terminationGracePeriodSeconds | int | `60` | Override Vector's terminationGracePeriodSeconds. |
| tolerations | list | `[]` | Configure Vector Pods to be scheduled on [tainted](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) nodes. |
| topologySpreadConstraints | list | `[]` | Configure [topology spread constraints](https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/) for Vector Pods. Valid for the "Aggregator" and "Stateless-Aggregator" roles. |
Expand Down
3 changes: 3 additions & 0 deletions charts/vector/templates/_pod.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ securityContext:
{{- with .Values.podPriorityClassName }}
priorityClassName: {{ . }}
{{- end }}
{{- with .Values.shareProcessNamespace }}
shareProcessNamespace: {{ . }}
{{- end }}
{{- with .Values.dnsPolicy }}
dnsPolicy: {{ . }}
{{- end }}
Expand Down
4 changes: 4 additions & 0 deletions charts/vector/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ dnsConfig: {}
# value: "2"
# - name: edns0

# shareProcessNamespace -- Specify the [shareProcessNamespace](https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/)
# options for Vector Pods.
shareProcessNamespace: false

# livenessProbe -- Override default liveness probe settings. If customConfig is used, requires customConfig.api.enabled
# to be set to true.
livenessProbe: {}
Expand Down

0 comments on commit f9e8f0e

Please sign in to comment.