Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vector): Add namespace to manifests #394

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(vector): Add namespace to manifests #394

merged 1 commit into from
Jun 24, 2024

Conversation

mustdiechik
Copy link
Contributor

To prevent argo CD InvalidSpecError

jszwedko
jszwedko reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mustdiechik ! I think you'll need to bump the chart version.

@jszwedko jszwedko changed the title Added "namespace" to manifests fix(vector): Add namespace to manifests Jun 21, 2024
Added "namespace" to manifests
a6cd178 
To prevent argo CD InvalidSpecError
jszwedko
jszwedko approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mustdiechik

@jszwedko jszwedko enabled auto-merge (squash) June 24, 2024 19:26
@jszwedko jszwedko merged commit 72ffb20 into vectordotdev:develop Jun 24, 2024
6 of 8 checks passed
jszwedko added a commit that referenced this pull request Jul 29, 2024
@jszwedko
Revert "fix(vector): Add namespace to manifests (#394)"
d29b4c7 
This reverts commit 72ffb20.
@jszwedko jszwedko mentioned this pull request Jul 29, 2024
Merged
jszwedko added a commit that referenced this pull request Jul 29, 2024
@jszwedko
fix(vector): Revert add namespace to manifests" (#401)
d975a43 
Revert "fix(vector): Add `namespace` to manifests (#394)"

This reverts commit 72ffb20.
@jszwedko
Copy link
Member

Just an FYI that I had to revert this since it caused a CI failure:

>>> helm lint charts/vector --values charts/vector/ci/datadog-values.yaml
==> Linting charts/vector
Error:  templates/: template: vector/templates/secret.yaml:6:24: executing "vector/templates/secret.yaml" at <.Release.Namespace>: nil pointer evaluating interface {}.Namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustdiechik @jszwedko