Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added residential address indicator at address builder #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thejackwu
Copy link

No description provided.

@calvinhughes
Copy link

According to the most recent docs, the correct tag to use is ResidentialAddress instead of ResidentialAddressIndicator.

Also, I think we should try to follow the behaviour of the UPS API for the passed options. The default behaviour for the ResidentialAddress tag when it's not passed is that it's treated as commercial and this is reclassified by UPS. With this change we're marking every address as residential, so I think we should only add this tag if some option is passed to the address builder (like residential_address)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants