Add id search to dataflow viewer #1379
Conversation
| @@ -198,7 +198,7 @@ class Editor extends React.PureComponent<Props> { | |||
| prevProps.editorRef && prevProps.editorRef.deltaDecorations(prevProps.decorations, []); | |||
| } | |||
|
|
|||
| if (this.props.parse) { | |||
| if (this.editor && this.props.parse) { | |||
There was a problem hiding this comment.
Not sure what this is, but i couldn't get the editor to run local without it?
There was a problem hiding this comment.
Thanks for the feature. Let's make this look a bit nicer. Let's all caps ID. Maybe we can add some spacing to the button, make it inline with the input (IDs are short), make the button full width like the input, or even remove the button and search immediately on change. Also, should we use type search (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search)?
|
Thanks for this thoughtful feedback. I believe i've addressed all of it, you can see a preview here: 
I found this to be a little bit jerky when i was trying it out, but happy to change over if you feel strongly |
When debugging things in the vega data flow graph sometimes it can be tedious to have to manually search for a particular node of interest. This adds a very simple id search which allows the user to search for a particular node