New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use parcel instead of vite #1420

Merged

domoritz merged 6 commits into master from dom/parcel

May 27, 2024

Member

domoritz commented May 27, 2024

fixes #1346

domoritz added 6 commits

May 27, 2024 14:19


          feat: use parcel instead of vite

3b2e654


          Merge branch 'master' into dom/parcel

28e2acf

# Conflicts:
#	package.json
#	yarn.lock


          Update lock

3e555f1


          update deps

50e3f2f


          no buffer

dfe6bab


          no process

d50ac5a

domoritz merged commit efbb70b into master

1 check passed

domoritz deleted the dom/parcel branch

May 27, 2024 18:40

hydrosquall mentioned this pull request

build: switch bundler for deploy previews back to parcel vega/vega-lite#9362

Merged

hydrosquall added a commit to vega/vega-lite that referenced this pull request


          build: switch bundler for deploy previews back to parcel (#9362)

b3c69bb

## Motivation

- Following vega/editor#1420,
#9276 stopped working
- This updates the build command for compatibility with parcel.

## Changes

- Updates stale comments
- Don't mention vite, try to stick to the yarn build command (with 1
parcel specific flag
parcel-bundler/parcel#206 (comment)
)

## Testing

- Check if deploy preview link loads correctly (
[src](https://cameron-yick-fix-deploy-prev.vega-lite.pages.dev/#/url/vega-lite/N4IgJAzgxgFgpgWwIYgFwhgF0wBwqgegIDc4BzJAOjIEtMYBXAI0poHsDp5kTykBaADZ04JAKyUAVhDYA7EABoQAEzjQATjRyZ289AEEABBBoIcguIaZJ1h2DcyGA7nRiHETOMtXLDypJhUiioBKKigxEiCDGpoANqgYSD6wUxoAEwAHAC+ColoIABCqWhiYrn56ADCJagALADMFSBJACK1AJwAjM1JAKK1mT15LQUAYrViTSNJAOK1XR29BQASgwDsy+gAkpPp2QC6uSDI6gDWBdbqwXCyUGzKNLJkaKAAHq8gAGY0cILKBRQSkwAE8cHACrI2AgnlFgkg3jQIJ9BEhPIJ9M8LGgAAzZY4gz4-P4A9BpYFgiHoACODCQsh0gR0pBA+OyQA)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet