Modification of watching logic. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #20
Changes the logic of applying
onBeforeReloadhandler to a batch of events.Due to debouncing the function
_reloadCodecan receive a batch of events. WhenonBeforeReloaddiscards some of them, all the batch is discarded and hot-reloading is skipped. The PR changes this logic: hot-reloading is skipped only if all of the events are discarded.Supports
excludedPaths.When
watchDependenciesistrue, the HotReloader starts watching all dependencies including the entire project. To prevent watching some of relative dependencies or entire project, this PR proposes theexcludedPathsargument.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.