Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash loop on renamed registration file #52

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

dermalikmann
Copy link
Contributor

@dermalikmann dermalikmann commented Apr 16, 2024

When the user (e.g. "Me") decides to rename the file with the registration info, this could end in two ways, depending if $GITEA_RUNNER_REGISTRATION_TOKEN_FILE and $GITEA_RUNNER_REGISTRATION_TOKEN are set:

  1. If one or both env var(s) is/are set, the runner will re-register on every restart of the container, resulting in numerous "offline" runners in gitea.
  2. If neither env var is set, the runner will run into a crash loop, as it expects the .runner file or a token-source, neither of which are available.

PS: I was not able to test this as I ran into issues every step on the way to building the image.

@sebthom sebthom merged commit a42e95b into vegardit:main Apr 16, 2024
6 checks passed
@sebthom
Copy link
Member

sebthom commented Apr 16, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants