Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fetch all Relays from Registry's factories #26

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ethzoomer
Copy link
Contributor

The Registry contract's getAll returns a list of Factory contracts. Iterates through all of the Factory contracts to fetch all of their Relays.

@ethzoomer ethzoomer requested a review from stas September 14, 2023 23:16
Copy link
Collaborator

@stas stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can see where the confusion was. :shipit:

@ethzoomer ethzoomer merged commit 43b45fd into v2-autocompounder Sep 15, 2023
0 of 2 checks passed
@stas stas deleted the v2-autocompounder-registry branch September 19, 2023 10:42
ethzoomer added a commit that referenced this pull request Sep 25, 2023
* add RelaySugar

* Account deposits() function, add inactive field

* Relay struct flattened (#20)

* Relay struct flattened

* Add account veNFT ids to Relay struct

* Remove VeSugar dependency

* Remove Deposit struct and function

* Vyper range bound check

* byId() -> byAddress()

* feat: use RelayFactory, add latest epoch compounded rewards (#22)

* feat: use RelayFactory, add latest epoch compounded rewards

* refactor: rename rewards_compounded

* refactor: fetch Relays from Registry (#24)

* refactor: fetch all Relays from Registry's factories (#26)

* feat: add run_at to Relay struct output (#27)

* Add Relay to readme

* Add Relay tests
ethzoomer added a commit to aerodrome-finance/sugar that referenced this pull request Apr 19, 2024
* add RelaySugar

* Account deposits() function, add inactive field

* Relay struct flattened (#20)

* Relay struct flattened

* Add account veNFT ids to Relay struct

* Remove VeSugar dependency

* Remove Deposit struct and function

* Vyper range bound check

* byId() -> byAddress()

* feat: use RelayFactory, add latest epoch compounded rewards (velodrome-finance#22)

* feat: use RelayFactory, add latest epoch compounded rewards

* refactor: rename rewards_compounded

* refactor: fetch Relays from Registry (velodrome-finance#24)

* refactor: fetch all Relays from Registry's factories (velodrome-finance#26)

* feat: add run_at to Relay struct output (velodrome-finance#27)

* Add Relay to readme

* Add Relay tests
ethzoomer added a commit to aerodrome-finance/sugar that referenced this pull request Apr 19, 2024
* add RelaySugar

* Account deposits() function, add inactive field

* Relay struct flattened (#20)

* Relay struct flattened

* Add account veNFT ids to Relay struct

* Remove VeSugar dependency

* Remove Deposit struct and function

* Vyper range bound check

* byId() -> byAddress()

* feat: use RelayFactory, add latest epoch compounded rewards (velodrome-finance#22)

* feat: use RelayFactory, add latest epoch compounded rewards

* refactor: rename rewards_compounded

* refactor: fetch Relays from Registry (velodrome-finance#24)

* refactor: fetch all Relays from Registry's factories (velodrome-finance#26)

* feat: add run_at to Relay struct output (velodrome-finance#27)

* Add Relay to readme

* Add Relay tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants