-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1 pools from LpSugar #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, but we'll have to remove the old v1 interface definitions, see the Aero fork for more context:
aerodrome-finance@02a9f33#diff-638bd86befbbe9f223dd728ed1b93f11689693558456f317ddd73761f60b77f5L102
contracts/LpSugar.vy
Outdated
@@ -311,24 +311,20 @@ def forSwaps(_limit: uint256, _offset: uint256) -> DynArray[SwapLp, MAX_POOLS]: | |||
|
|||
factory: IPoolFactory = IPoolFactory(factories[index]) | |||
|
|||
if factory.address == self.v1_factory: | |||
continue | |||
|
|||
pools_count: uint256 = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this can be inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏃♂️
@@ -214,88 +197,11 @@ def _pools(with_convertor: bool) -> DynArray[address[3], MAX_POOLS]: | |||
|
|||
return pools | |||
|
|||
@external | |||
@view | |||
def toMigrate(_account: address) -> DynArray[Lp, MAX_POOLS]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ethzoomer this is still used by the dapp, I'm down to remove the migration, but will need it cleaned up from the app
repo as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make app Linear task and start working on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty ty, this is good to merge otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, just need to sync up with the dapp.
* Remove v1 pools from LpSugar * Remove all v1 calls from LpSugar * Point to latest LpSugar deployment * Add latest LpSugar address
* Remove v1 pools from LpSugar * Remove all v1 calls from LpSugar * Point to latest LpSugar deployment * Add latest LpSugar address
No description provided.