feat: add ALM vault to LpSugar #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrovalido
approved these changes
Jul 26, 2024
stas
approved these changes
Jul 31, 2024
stas
reviewed
Jul 31, 2024
stas
force-pushed
the
alm
branch
2 times, most recently
from
0838877
to
0b2766d
Compare
stas
reviewed
Aug 5, 2024
pedrovalido
reviewed
Aug 6, 2024
tests/test_lp_sugar.py
Outdated
There was a problem hiding this comment.
Leaving this here as a suggestion (also fine if it's not implemented). This has already been tested in the FE so it's only for redundancy.
Instead of having the
assert pos.id is not None
assert pos.lp is not None
assert pos.alm is not None
we would
assert pos.id == <expected_id>
assert pos.lp == <expected_lp>
assert pos.alm == <expected_alm>
7ee54d9
to
d112ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.