[ultra] Require nrepl or clojure.tools.nrepl dynamically #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clojure.tools.nrepl is now officially deprecated and has been replaced with nrepl/nrepl. This commit updates all direct references to clojure.tools.nrepl to use a dynamic import that checks to see if clojure.tools.nrepl is on the path and otherwise to use the new nrepl. As we rely on a significant amount of functionality in Whidbey/Puget, those will also need to have their references updated.
|
@venantius any updates on this issue (#95)? i see greglook/whidbey#26 is already resolved |
|
I'll try to give this a look over the weekend. |
|
@venantius Thanks for looking at this, any chance we could get it over the line please? |
|
Leiningen 2.9.0 has introduced some sort of new issue that needs to be resolved upstream again - not totally clear what it is yet. I could try to fix this just for Lein 2.8.3 but I'd rather just fix it for 2.9.0 onwards. |
|
Reference: greglook/whidbey#27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clojure.tools.nrepl is now officially deprecated and has been replaced
with nrepl/nrepl. This commit updates all direct references to
clojure.tools.nrepl to use a dynamic import that checks to see if
clojure.tools.nrepl is on the path and otherwise to use the new nrepl.
As we rely on a significant amount of functionality in Whidbey/Puget,
those will also need to have their references updated.
This PR resolves #95