Support for is_in operator #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
business_rules/operators.py
Outdated
| @@ -95,6 +95,10 @@ def matches_regex(self, regex): | |||
| def non_empty(self): | |||
| return bool(self.value) | |||
|
|
|||
| @type_operator(FIELD_TEXT) | |||
| def contains_in(self, other_string): | |||
There was a problem hiding this comment.
How about just "is_in"? Contains_in isnt't really a thing people say.
There was a problem hiding this comment.
Yup, it really fits what we are trying to do
KaranTrueAccord
changed the title
| @@ -96,7 +96,7 @@ def non_empty(self): | |||
| return bool(self.value) | |||
|
|
|||
| @type_operator(FIELD_TEXT) | |||
| def contains_in(self, other_string): | |||
| def is_in(self, other_string): | |||
There was a problem hiding this comment.
You really need a substring option? Or are you intending this to be about membership in a list of things?
|
@jfalkenstein Do you know who maintains this repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this Rules Engine has the support to check if the value has the other string. There are use cases where a person may want to see if the value is part of the other string.