Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align OpenAPI definition to real servers behaviour #50

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

Akretsch
Copy link
Contributor

The server returns the AttestationResult wrapped in an JWS and not as plain '#/components/schemas/AttestationResult' as specified in api/challenge-response/schemas/components.yaml

Align schema to current implementatio
@Akretsch Akretsch changed the title Align OPenAPI definition to real servers behaviour Align OpenAPI definition to real servers behaviour Jan 23, 2024
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

I think we can also drop AttestationResult from the schema because it has now been absorbed by the EAR spec, and it makes no sense to have a copy here.

api/challenge-response/schemas/components.yaml Outdated Show resolved Hide resolved
@thomas-fossati thomas-fossati merged commit a02a95a into veraison:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants