Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ARM CCA Realm Provisioning and Verification #233

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Introduce ARM CCA Realm Provisioning and Verification #233

merged 1 commit into from
Jun 24, 2024

Conversation

yogeshbdeshpande
Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande commented Jun 17, 2024 •
edited
Loading

  1. Refactor common to move CCA out of common/arm
  2. Implement CCA Realm provisioning profile
  3. Implement CCA Realm Verification part
  4. Correct existing test cases to make Integration Tests to pass!

@yogeshbdeshpande yogeshbdeshpande changed the title Cca comb plugin 13 6 Introduce ARM CCA Realm Provisioning and Verification Jun 17, 2024
@yogeshbdeshpande yogeshbdeshpande mentioned this pull request Jun 17, 2024
Closed
@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review June 17, 2024 16:02
@yogeshbdeshpande yogeshbdeshpande mentioned this pull request Jun 17, 2024
Closed
@yogeshbdeshpande
Copy link
Collaborator Author

Issue #235 to address further work on Integration Test Cases...

@yogeshbdeshpande yogeshbdeshpande mentioned this pull request Jun 17, 2024
Closed
@yogeshbdeshpande yogeshbdeshpande force-pushed the cca-comb-plugin-13-6 branch 9 times, most recently from c1408df to f62c470 Compare June 17, 2024 17:35
setrofim
setrofim requested changes Jun 18, 2024
View reviewed changes
scheme/psa-iot/psa_extractor.go Outdated Show resolved Hide resolved
scheme/common/cca/realm/cca_realm_attributes.go Outdated Show resolved Hide resolved
scheme/common/cca/realm/cca_realm_extractor.go Outdated Show resolved Hide resolved
scheme/common/cca/realm/realm_utils.go Outdated Show resolved Hide resolved
scheme/common/arm/handlers.go Outdated Show resolved Hide resolved
scheme/common/arm/handlers.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/arm-cca/platform.go Outdated Show resolved Hide resolved
scheme/arm-cca/realm.go Outdated Show resolved Hide resolved
setrofim
setrofim approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

thomas-fossati
thomas-fossati reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some half-way through comments

scheme/arm-cca/corim_extractor.go Outdated Show resolved Hide resolved
scheme/arm-cca/corim_extractor.go Outdated Show resolved Hide resolved
scheme/arm-cca/corim_extractor.go Outdated Show resolved Hide resolved
scheme/arm-cca/corim_extractor.go Outdated Show resolved Hide resolved
scheme/arm-cca/corim_extractor.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler_test.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler_test.go Outdated Show resolved Hide resolved
scheme/arm-cca/evidence_handler_test.go Show resolved Hide resolved
@yogeshbdeshpande
Copy link
Collaborator Author

Thank You @thomas-fossati for your comments, look forward to see the remaining before making the changes!

thomas-fossati
thomas-fossati reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late comment, I just noticed that...

scheme/common/arm/platform/iMeasurement.go Outdated Show resolved Hide resolved
@yogeshbdeshpande yogeshbdeshpande force-pushed the cca-comb-plugin-13-6 branch 2 times, most recently from d5e0b0e to af3be7e Compare June 24, 2024 14:52
@yogeshbdeshpande @thomas-fossati
feat(scheme)!: implement CCA realm provisioning and verification
70d567e 
1. add "composite" Arm CCA scheme
2. add CCA Realm provisioning and verification
3. refactor common CCA components for use by other CCA-based schemes
4. modify integration tests take care of composite attesters

BREAKING CHANGE: the EAR for CCA appraisal has a new “CCA_REALM” submod with details about Realm appraisal

Signed-off-by: Yogesh Deshpande <[email protected]>
thomas-fossati
thomas-fossati approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the herculean work :-)

@thomas-fossati thomas-fossati merged commit 80fec89 into main Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@setrofim setrofim setrofim approved these changes

@thomas-fossati thomas-fossati thomas-fossati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yogeshbdeshpande @setrofim @thomas-fossati