Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(turbopack): Document build dependency on clang for rocksdb #72493

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

bgw
Copy link
Member

@bgw bgw commented Nov 8, 2024

Noticed this after rebuilding on top of #71688

Most Linux distributions default to gcc for their default cc implementation (e.g. via Debian's build-essential meta-package, which we can probably implicitly assume is installed), which means that they won't typically have clang installed.

librocksdb-sys seems to always depend on clang on Linux. It looks like this might be a consequence of using rust-bindgen (though I'm confused why this didn't come up earlier), as it looks like rocksdb can otherwise build with gcc.

This shouldn't be an issue for macos, since clang is the default cc on that platform.

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Nov 8, 2024
Copy link
Member Author

bgw commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bgw and the rest of your teammates on Graphite Graphite

@bgw bgw marked this pull request as ready for review November 8, 2024 05:17
@bgw bgw requested a review from sokra November 8, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants