Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update github actions #7224

Closed
wants to merge 29 commits into from
Closed

chore: update github actions #7224

wants to merge 29 commits into from

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Feb 1, 2024 •
edited
Loading

Description

The node16 runner is deprecated, I updated all the actions I could here.

Still missing:
https://github.com/pnpm/action-setup (removed in favor of corepack, but that needs to be tested)
https://github.com/technote-space/get-diff-action (archived, needs to be replaced) replacement: https://github.com/dorny/paths-filter
https://github.com/dependabot/fetch-metadata (has PR: dependabot/fetch-metadata#443)
https://github.com/ts-graphviz/setup-graphviz (has PR: ts-graphviz/setup-graphviz#558)
https://github.com/thomaseizinger/create-pull-request

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:51pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:51pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:51pm
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:51pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 5:51pm

@mehulkar mehulkar mentioned this pull request Feb 8, 2024
Closed
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch from de87d02 to 514fb53 Compare February 8, 2024 17:33
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review February 8, 2024 18:26
@ForsakenHarmony ForsakenHarmony requested review from a team as code owners February 8, 2024 18:26
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch from 514fb53 to 5888c80 Compare February 8, 2024 18:42
mehulkar

This comment was marked as resolved.

Sign in to view

mehulkar
mehulkar requested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some glibc missing issue for both our release workflows. We'd need to work those out before merge

mehulkar
mehulkar reviewed Feb 8, 2024
View reviewed changes
.github/workflows/lsp.yml Outdated Show resolved Hide resolved
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch 4 times, most recently from d465c58 to 24f89c2 Compare February 9, 2024 00:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turborepo integration tests
  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

✅ This change can build next-swc

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch 2 times, most recently from 8ed0ca3 to 4bfa5aa Compare February 9, 2024 23:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Linux Benchmark for aa0ac1c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.60ms ± 0.09ms 22.50ms ± 0.07ms -0.47%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.40ms ± 0.06ms 21.60ms ± 0.09ms +0.91%
bench_startup/Turbopack CSR/1000 modules 953.66ms ± 5.32ms 946.53ms ± 5.15ms -0.75%

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch from 4bfa5aa to 0eb283a Compare February 10, 2024 00:42
@github-actions GitHub Actions
Copy link
Contributor

Linux Benchmark for f5be4fa

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 22.57ms ± 0.07ms 22.52ms ± 0.12ms -0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 21.43ms ± 0.10ms 21.44ms ± 0.08ms +0.03%
bench_startup/Turbopack CSR/1000 modules 934.26ms ± 4.25ms 939.96ms ± 6.46ms +0.61%

@ForsakenHarmony
fix status comment action
ebf9e0b
@ForsakenHarmony
fix status comment action again
c5290af
@ForsakenHarmony
update graphviz
b22b116
@ForsakenHarmony
more node20 (and try library release without container)
46999e1
@ForsakenHarmony
don't merge release artifacts
4946727
@ForsakenHarmony
version typo
59ab154
@ForsakenHarmony
remove container from lsp
e6c293c
@ForsakenHarmony
fix status comment
88d7787
@ForsakenHarmony
fix lsp default host
bb24e91
@ForsakenHarmony
skip status comment for skipped runs
61cbd98
@ForsakenHarmony
comment
f23095c
@ForsakenHarmony
try fixing lsp workflow
2263f9e
@ForsakenHarmony
nvm fixing lsp workflow
bfde283
@ForsakenHarmony
fix next-swc status comment
c64ec5a
@ForsakenHarmony
missed the peter-evans/create-or-update-comment version
2e007a7
@ForsakenHarmony
bust cache by removing old cargo group
33ba854
@ForsakenHarmony
fix bench
4b62ca3
@ForsakenHarmony
try fixing corepack
819371e
@ForsakenHarmony
use default github token for protoc install
1e98f2a
@ForsakenHarmony
update ahash
53dfa7c
@ForsakenHarmony
print rust toolchain before build
6137ff0
@ForsakenHarmony
try to set up rust after node
d5650c1
@ForsakenHarmony
dbg
db5918c
@ForsakenHarmony
bring back windows input for turborepo
d860f85
@ForsakenHarmony
fix musl build
24c2903
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/update-github-actions branch from a4327c3 to 24c2903 Compare March 6, 2024 17:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Linux Benchmark for 80dedcf

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 24.20ms ± 0.12ms 24.26ms ± 0.11ms +0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 23.29ms ± 0.13ms 23.34ms ± 0.15ms +0.23%
bench_startup/Turbopack CSR/1000 modules 903.58ms ± 1.49ms 910.09ms ± 6.12ms +0.72%

@anthonyshew
Copy link
Contributor

Will close this as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@arlyon arlyon arlyon approved these changes

@mehulkar mehulkar mehulkar approved these changes

@Zertsov Zertsov Awaiting requested review from Zertsov Zertsov is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ForsakenHarmony @anthonyshew @mehulkar @arlyon @kdy1