Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependecies jest, @types/jest and ts-jest #8756

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

torresgol10
Copy link
Contributor

I upgraded the jest, @types/jest and ts-jest dependencies to the latest version, because in every pnpm install there was a warning for the ts-jest library and in the future I wanted to upgrade to typescript 5.5.3 in all packages.

In order to update jest it was necessary to update ts-jest and vice versa, although I didn't want to make a PR with both updates they are totally related and you can't update one library without updating the other.

In the packages/turbo-test-utils, I removed the jest, @types/jest and ts-jest dependencies, as they were not used in this package node:test is used.

In order to move from jest to the latest version and keep everything working the same without touching code, I had to update the configuration of jest when doing snapshop to leave the configuration that had before to be able to default, put it url of the documentation, without putting this configuration all the tests failed: https://jestjs.io/docs/upgrading-to-jest29#snapshot-format

In all jest configurations, now InitialOptionsTsJest is marked as deprecated and changed to JestConfigWithTsJest.

@torresgol10 torresgol10 requested review from a team as code owners July 15, 2024 21:28
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-telemetry pkg: turbo-workspaces labels Jul 15, 2024
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:34am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:34am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:34am
examples-svelte-web ❌ Failed (Inspect) Jul 19, 2024 3:34am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:34am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2024 3:34am

Copy link

vercel bot commented Jul 15, 2024

@torresgol10 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Jul 15, 2024

Allow CI Workflow Run

  • approve CI run for commit: 169bedb

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bgw bgw removed the request for review from a team August 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage owned-by: turborepo pkg: create-turbo Issues related to npx create-turbo pkg: turbo-codemod pkg: turbo-eslint eslint-config-turbo and eslint-plugin-turbo pkg: turbo-gen pkg: turbo-ignore packages/turbo-ignore pkg: turbo-telemetry pkg: turbo-workspaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants