Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbo): add platform env support #9122

Merged
merged 8 commits into from
Oct 15, 2024
Merged

feat(turbo): add platform env support #9122

merged 8 commits into from
Oct 15, 2024

Conversation

tknickman
Copy link
Member

@tknickman tknickman commented Sep 6, 2024 •
edited
Loading

Description

Support reading what variables are set by a user in CI, and diffing those with those in the execution environment.

Testing

TURBO_SYSTEM_ENV=THIS_NEAT_ENV,SUPER_COOL,TEST THIS_NEAT_ENV=1 ./target/debug/turbo build --skip-infer --force --cwd examples/basic

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 5:50pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 5:50pm

@linear Linear
Copy link

linear bot commented Sep 6, 2024

TURBO-4007 Support TURBO_PLATFORM_ENV

@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 8bc0d6b to 6887030 Compare October 11, 2024 20:35
@tknickman tknickman marked this pull request as ready for review October 11, 2024 20:35
@tknickman tknickman requested a review from a team as a code owner October 11, 2024 20:35
@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 6887030 to 93057e1 Compare October 11, 2024 20:36
@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 93057e1 to 171d7b0 Compare October 11, 2024 20:38
@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 524ac9d to d238df2 Compare October 15, 2024 14:23
@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 15133f5 to b305d6d Compare October 15, 2024 15:35
chris-olszewski
chris-olszewski approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Only thing that needs changing is moving all the outputs to stderr to avoid breaking uses of turbo --dry=json that might happen in CI.

crates/turborepo-lib/src/task_graph/visitor.rs Outdated Show resolved Hide resolved
crates/turborepo-lib/src/task_graph/visitor.rs Outdated Show resolved Hide resolved
crates/turborepo-env/src/platform.rs Outdated Show resolved Hide resolved
@tknickman tknickman force-pushed the tomknickman/turbo-4007-support-turbo_platform_env branch from 3ac518f to 436bc5e Compare October 15, 2024 17:48
@tknickman tknickman enabled auto-merge (squash) October 15, 2024 17:49
@tknickman tknickman merged commit b5fefe8 into main Oct 15, 2024
39 checks passed
@tknickman tknickman deleted the tomknickman/turbo-4007-support-turbo_platform_env branch October 15, 2024 18:26
@anthonyshew anthonyshew mentioned this pull request Oct 22, 2024
Merged
@renovate renovate bot mentioned this pull request Nov 5, 2024
Open
4 tasks
@Lavish1999 Lavish1999 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees

@chris-olszewski chris-olszewski

@NicholasLYang NicholasLYang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tknickman @chris-olszewski @NicholasLYang