Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual move #2805

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Fix manual move #2805

merged 2 commits into from
Nov 9, 2024

Conversation

MohamedElgammal
Copy link
Contributor

Description

This PR is a follow-up on PR #2804 to fix a segmentation fault that happens during manual moves after the latest refactors. It also adds an widget for the layer in the manual move prompt.

Related Issue

The manual move was facing segmentation fault due to 2 reasons:

  1. The global instance of BlkLocRegistry was used instead the one stored in placer_state_ --> fixed in PR Fix segmentation fault when moving blocks manually #2804 but still after this fix, whenever the user accepts or rejects the move, it will result in a seg fault.
  2. After the move, the code is trying to update the RL agent Q table and the move statistics while the move type is manual (not recognized by the agent) --> fixed in this PR

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Nov 9, 2024
@vaughnbetz vaughnbetz merged commit 91f2941 into master Nov 9, 2024
37 checks passed
@vaughnbetz vaughnbetz deleted the fix_manual_move_cont branch November 9, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants