Fixes for 17.0 mig report qweb pdf watermark #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dz0
force-pushed
the
17.0-mig-report_qweb_pdf_watermark
branch
from
6a8cae3
to
0dda145
Compare
oerp-odoo
reviewed
Aug 12, 2024
| stream.seek(0, os.SEEK_SET) | ||
| header_byte = stream.read(5) | ||
| if header_byte != b"%PDF-": | ||
| # the file is not PDF -- probably this is image (we'll check bellow) |
There was a problem hiding this comment.
Is this module supposed to handle images as well? Cause from name I would assume it only handles pdfs:)
dz0
commented
Aug 12, 2024
oerp-odoo
approved these changes
Aug 12, 2024
dz0
force-pushed
the
17.0-mig-report_qweb_pdf_watermark
branch
from
fbb901b
to
4a7f469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 2 non-apparent issues