Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.0 mig mail notification custom subject #3

Merged

Conversation

maciej-wichowski
Copy link

23132

joao-p-marques and others added 23 commits April 9, 2024 11:39
…l notifications

This module allows you to specify templates to override the subject on the notification
emails sent by Odoo.

TT27191

Co-authored-by: Pedro M. Baeza <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-mail_notification_custom_subject
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/
… send messages

After installing the module, any user was required to have admin rights to be able to search across models.

This fix does just that search with sudo and returns back to non-sudo mode immediately after. This way, we don't need to increase permissions for everybody.

Tests now run unprivileged, to assert this problem never happens again.

@moduon MT-1644 MT-1645
@maciej-wichowski maciej-wichowski force-pushed the 17.0-mig-mail_notification_custom_subject branch from 5d20db4 to fde4ba0 Compare April 9, 2024 10:14
Copy link

@Drsmartinkus Drsmartinkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciej-wichowski I checked only last commit. [MIG] mail_notification_custom_subject: migration to 17.0

@@ -26,7 +26,7 @@ def message_post(
attachment_ids=None,
add_sign=True,
record_name=False,
**kwargs
**kwargs,
Copy link

@Drsmartinkus Drsmartinkus Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need comma here? Or is that pre-commit thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a black thing I believe :)

@maciej-wichowski maciej-wichowski merged commit ff69b21 into 17.0-versada Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.