Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow createEncodedStreams on PCs without encodedInsertableStreams parameter #300

Conversation

kjvenalainen
Copy link
Contributor

Fixes #299

Allows calling clients to add sender and receiver callback functions which are executed synchronously after RTCRTPSender/Receiver creation. This feature is targeted to Chromium browsers and allows applications to call createEncodedStreams() in the callback functions in order to create WebRTC Encoded Transforms.

Example Usage

const consumer = await recvTransport.consume({
  xxxxx,
  xxxxx,
  onRtpReceiver: (receiver) => {
    const { readable, writable } = receiver.createEncodedStreams();
    readable.pipeTo(writable);
  }
});

@@ -34,11 +34,18 @@ export type HandlerRunOptions = {
extendedRtpCapabilities: any;
};

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** please

@@ -47,6 +54,12 @@ export type HandlerSendResult = {
rtpSender?: RTCRtpSender;
};

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@ibc
Copy link
Member

ibc commented Jun 13, 2024

I tried to push to this repo following GH instructions and... ended creating another PR #301 by accident (not sure what I did wrong). Let's continue in there. Sorry.

@ibc ibc closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow createEncodedStreams on PCs without encodedInsertableStreams parameter
3 participants