Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sprop-stereo handling #312

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix sprop-stereo handling #312

merged 3 commits into from
Nov 26, 2024

Conversation

ggarber
Copy link
Contributor

@ggarber ggarber commented Nov 26, 2024

When sprop-stereo is "0" we are still assuming that is enabled and enabling stereo decoding.

Note: This fix could break stereo working for some implementations.

When sprop-stereo is "0" we are still assuming that is enabled and enabling stereo decoding.
@ibc
Copy link
Member

ibc commented Nov 26, 2024

Wow. Checking this morning and will release later.

@ibc
Copy link
Member

ibc commented Nov 26, 2024

Note: This fix could break stereo working for some implementations.

It could just break scenarios where some NON mediasoup-client sender is sending stereo audio without properly signaling it in RtpParameters.codecs['opus'], right?

@ibc ibc merged commit a632529 into versatica:v3 Nov 26, 2024
7 checks passed
@ibc
Copy link
Member

ibc commented Nov 26, 2024

Released in mediasoup-client 3.7.18. Thanks

@ggarber
Copy link
Contributor Author

ggarber commented Nov 26, 2024

Note: This fix could break stereo working for some implementations.

It could just break scenarios where some NON mediasoup-client sender is sending stereo audio without properly signaling it in RtpParameters.codecs['opus'], right?

If the server was signaling "sprop-stereo=0" before stereo was still working. Now with those servers it will stop working.

@ggarber ggarber deleted the ggarber-patch-2 branch November 26, 2024 12:12
@ibc
Copy link
Member

ibc commented Nov 26, 2024

If the server was signaling "sprop-stereo=0" before stereo was still working. Now with those servers it will stop working.

The server will send "sprop-stereo=0" or "=1" based on client given RtpParameters so we are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants