Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard: support all key conversions #69

Open
pewsheen opened this issue Jul 3, 2024 · 3 comments
Open

keyboard: support all key conversions #69

pewsheen opened this issue Jul 3, 2024 · 3 comments
Labels
E-less-complex Straightforward. Recommended for a new contributor. good first issue Good for newcomers

Comments

@pewsheen
Copy link
Collaborator

pewsheen commented Jul 3, 2024

Follow up from #67

Super, Capslock are not recognized by the webview.

@wusyong wusyong self-assigned this Jul 3, 2024
@wusyong
Copy link
Member

wusyong commented Jul 4, 2024

I think this is simply because we haven't supported all key conversions. We can use this issue as feature request to add more key supports.

@wusyong wusyong changed the title [Keyboard] Super Capslock are not working keyboard: support all key conversions Jul 4, 2024
@wusyong
Copy link
Member

wusyong commented Jul 4, 2024

There are three methods that haven't supported all conversions yet:

fn get_servo_key_from_winit_key(key: &LogicalKey) -> Key {

fn get_servo_location_from_physical_key(physical_key: PhysicalKey) -> Location {

fn get_servo_code_from_physical_key(physical_key: PhysicalKey) -> Code {

Feel free to open PR to add some conversions. We can add this step by step. Perhaps we can also open more issues to list out missing keys.

@wusyong wusyong removed their assignment Jul 4, 2024
@wusyong wusyong added good first issue Good for newcomers E-less-complex Straightforward. Recommended for a new contributor. labels Jul 4, 2024
@ByteBaker
Copy link
Contributor

Hi, I'd like to take this up.

github-merge-queue bot pushed a commit that referenced this issue Sep 3, 2024
* feat: add some more mappings as in #69

also add macros to generate code in `keyboard.rs` to
conveniently generate mappings

* fix: macros in keyboard.rs
- support custom match cases in key-mapping macros for when one-one
  mappings of keys aren't available
- add docs to the macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-less-complex Straightforward. Recommended for a new contributor. good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants