feat: add some more keyboard mappings #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteBaker
changed the title
|
It looks good overall |
|
Fair point. I think I'll just modify the macro to accept raw pattern blocks as well. This way if we ever need to, we can just add those patterns inside the macro invocation alongside the rest of the items as they're now. |
|
I've modified the macros and added documentation. Now they also support calls like This one in example maps |
also add macros to generate code in `keyboard.rs` to conveniently generate mappings
- support custom match cases in key-mapping macros for when one-one mappings of keys aren't available - add docs to the macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69 to support more key mappings
Also
env_logger: 0.10 -> 0.11,keyboard.rsto conveniently generate mappings