Build and install verso for flatpak #219
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Nov 6, 2024
| # Install Verso | ||
| - install -Dm755 ./target/release/versoview -t /app/bin/ | ||
| - install -Dm755 ./target/release/verso -t /app/bin/ |
There was a problem hiding this comment.
Do you mean we just change the flatpak's entry point to versoview?
There was a problem hiding this comment.
No I mean only versoview is used here right? So I'm think maybe there just need a install command.
There was a problem hiding this comment.
I'm not entirely sure what do you mean, do you want this flatpak to run versoview or verso? If verso then this is definitely needed right? If not we will change the command to versoview and don't build verso at all, so the entry point will be versoview right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #216