Fix the heartbeat issue #40 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and DefaultStompHandler. 2. Add unit test testAsymmetricHeartbeatTime to StompClientImplTest.
|
@deepsleep did you sign the Eclipse CLA? |
|
@cescoffier Sorry that I am not sure about that, since it's my first PR in Github. And sure I would like to sign the Eclipse CLA. |
|
@deepsleep you just have to create an account and sign the CLA on https://accounts.eclipse.org/user/login?destination=user/eca. The value behind this extra step is to be sure that the contribution is "cleared" in term of IP. You sign the CLA only once for all your contribution to Eclipse projects. |
|
Thanks @cescoffier. I have signed the Eclipse CLA. And my email address of Eclipse account is [email protected] . Thanks again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue Heartbeat configuration in the default stomp server handler appears to be incorrect #40 found in both StompClientConnectionImpl and DefaultStompHandler.
Add unit test testAsymmetricHeartbeatTime to StompClientImplTest.