WebClient failure when sending multipart formdata from a virtual thread #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MultipartFormUpload is created on the Vert.x context that is bound to the request promise. We should create the queue using the context executor for both the producer and consumer sides. Otherwise, if there is a large upload and the queue needs to be paused/resumed, the pump method will be invoked on the EventLoop executor bound to this context. And then the IllegalArgumentException is thrown. Signed-off-by: Thomas Segismont <[email protected]>
vietj
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2696
MultipartFormUploadis created on the Vert.x context that is bound to the request promise.We should create the queue using the context executor for both the producer and consumer sides.
Otherwise, if there is a large upload and the queue needs to be paused/resumed, the
pumpmethod will be invoked on the EventLoop executor bound to this context. And then the IllegalArgumentException is thrown.