Improved handling of comments around clauses/stanzas #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parno
approved these changes
Sep 24, 2024
Specifically, in the presence of comments around `expr_with_block`
cases (such as `assert ... by { ... }` blocks) that don't necessarily
have a semicolon, the previous version would end up reorganizing the
affinity of the comments across the clauses, preferring the previous
clause. With this commit, each comments stays loyal to its own clause.
jaybosamiya-ms
force-pushed
the
jb-commented-clause
branch
from
3d9e1e9
to
dec44e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, each comment now maintains loyalty to the clause the user picked it to stay with, rather than automatically migrating to the previous clause in the presence of
assert ... by { ... }-style constructs.See the newly introduced test which would fail before this PR.