add comment to explain corner case

vespa-engine · Dec 19, 2024 · 53a27ec · 53a27ec
1 parent 25d6293
commit 53a27ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lowercasing_test/src/tests/lowercasing/casingvariants_fastlib.cpp b/lowercasing_test/src/tests/lowercasing/casingvariants_fastlib.cpp
@@ -16,6 +16,8 @@ getUCS4Char(const char *src)
             fprintf(stderr, "Warning: extra character from '%s' -> U+%04x U+%04X\n",
                     input, result, extra);
         }
+        // mangle two characters into one fake UCS4 number
+        // (in theory we should compare vector<UCS4>, but this is good enough)
         result |= (extra << 16);
     }
     return result;

diff --git a/lowercasing_test/src/tests/lowercasing/casingvariants_vespalib.cpp b/lowercasing_test/src/tests/lowercasing/casingvariants_vespalib.cpp
@@ -21,6 +21,8 @@ getUCS4Char(const char *src)
             fprintf(stderr, "Warning: extra character from '%s' -> U+%04x U+%04X\n",
                     input, result, extra);
         }
+        // mangle two characters into one fake UCS4 number
+        // (in theory we should compare vector<UCS4>, but this is good enough)
         result |= (extra << 16);
     }
     return result;