Try to warn about all fields having inconsistent settings when they a… #33048
+93
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re used in a field set Note that this is not done for match settings, as that will change behavior, but we should probably do that change, as it might be wrong now (e.g. you can get 'text' matching when the 2 fields in a fieldset have matching 'exact' and 'word')
arnej27959
reviewed
Dec 18, 2024
There was a problem hiding this comment.
This looks problematic to me. The new text claims that "matching.getType()" will be used, but the "return" that you want to remove will prevent that from happening. So we must either do the change or change how we produce the new text. Also, it doesn't warn about all fields like the commit message would indicate.
make sure that we report back the original fieldset matching as the effective outcome for now.
|
I changed the warning (not behavior) for now, agree that we should do more here later. |
|
Thanks, looks good, needs a review |
arnej27959
deleted the
hmusum/warn-about-all-fields-with-inconsistent-settings-when-using-fieldset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re used in a field set
Note that this is not done for match settings, as that will change behavior, but we should probably do that change, as it might be wrong now (e.g. you can get 'text' matching when the 2 fields in a fieldset have matching 'exact' and 'word')
@bratseth or @arnej27959 might have opinions about this