Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for std::tie and tuples in the fwd mode #1094

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Add basic support for std::tie and tuples in the fwd mode #1094

merged 1 commit into from
Sep 16, 2024

Conversation

gojakuch
Copy link
Collaborator

No description provided.

@gojakuch
Copy link
Collaborator Author

@vgvassilev we should deprecate c++11 as you've suggested

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev
Copy link
Owner

@vgvassilev we should deprecate c++11 as you've suggested

Because of using index_sequence?

@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (b414202) to head (7639909).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files          55       55           
  Lines        8445     8445           
=======================================
  Hits         7960     7960           
  Misses        485      485
Files with missing lines Coverage Δ
include/clad/Differentiator/BuiltinDerivatives.h 100.00% <ø> (ø)
Files with missing lines Coverage Δ
include/clad/Differentiator/BuiltinDerivatives.h 100.00% <ø> (ø)

@gojakuch
Copy link
Collaborator Author

@vgvassilev we should deprecate c++11 as you've suggested

Because of using index_sequence?

yes and also the constexpr stuff. I'm guessing you might suggest using some reimplementation of the index_sequence?

@vgvassilev
Copy link
Owner

@vgvassilev we should deprecate c++11 as you've suggested

Because of using index_sequence?

yes and also the constexpr stuff. I'm guessing you might suggest using some reimplementation of the index_sequence?

Yeah, maybe in a separate compatibility header file...

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev
vgvassilev reviewed Sep 16, 2024
View reviewed changes
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash all commits into a commit with an appropriate commit message?

test/ForwardMode/STLCustomDerivatives.C Outdated
@@ -1,4 +1,4 @@
// RUN: %cladclang %s -std=c++14 -I%S/../../include -oSTLCustomDerivatives.out | %filecheck %s
// RUN: %cladclang -std=c++17 %s -I%S/../../include -oSTLCustomDerivatives.out | %filecheck %s
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need c++17 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't. I turned it on and forgot to switch it back to c++14.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

vgvassilev
vgvassilev approved these changes Sep 16, 2024
View reviewed changes
Copy link
Owner

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit c0c782c into vgvassilev:master Sep 16, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gojakuch @vgvassilev