Remove excessive parameters from Derive functions #1110
Merged
+207
−243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetroZarytskyi
force-pushed
the
derive-sign
branch
from
4f1484a
to
45562c3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
- Coverage 94.24% 94.21% -0.03%
==========================================
Files 55 48 -7
Lines 8447 8131 -316
==========================================
- Hits 7961 7661 -300
+ Misses 486 470 -16
... and 33 files with indirect coverage changes
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Can you fix the clang-tidy and code-cov complaints? Also please mention in the commit message that this partially addresses #721. |
PetroZarytskyi
force-pushed
the
derive-sign
branch
from
45562c3
to
473d711
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
derive-sign
branch
from
473d711
to
b112290
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
force-pushed
the
derive-sign
branch
from
b112290
to
9fc62a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derivefunctions have access to the original function and the diff request throughm_DiffRef, there's no need to pass those as parameters. The same applies tom_Functoras it's also stored inm_DiffRef.Partially addresses #721.