Update osx builds in ci to cover both x86 and arm #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 49 49
Lines 7478 7478
=======================================
Hits 7096 7096
Misses 382 382 |
|
@vgvassilev can you rerun the ci for me please? |
Done. |
|
@vgvassilev can you rerun the ci for me please? I've made another attempt at fixing the linking issue on osx arm, and added a runtime17 build for Windows. |
mcbarton
changed the title
|
@vgvassilev this PR is ready for review. |
alexander-penev
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev This PR updates the osx part of the CI to have fixed version numbers, and adds osx arm builds.