Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate UPF feature and tests #883

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

char-1ee
Copy link
Contributor

Summary

Integrate the firecracker snapshot UPF features and enable UPF tests.

Implementation Notes ⚒️

  • Enable UPF features and tests, refer to b6bfcbb
  • Update firecracker-containerd image default-rootfs.img
  • Update firecracker-containerd version
  • Update kernel image firecracker-containerd used

External Dependencies 🍀

Breaking API Changes ⚠️

  • NA

Simply specify none (N/A) if not applicable.

@ustiugov
Copy link
Member

@char-1ee Please fix the errors reported by the CI.

@ruiqi please assist with the runners if necessary. The kubectl error in the integration tests is strange

@ustiugov
Copy link
Member

@lrq619

@lrq619
Copy link
Collaborator

lrq619 commented Nov 16, 2023

Hi @char-1ee I've already re-launched the runners, they should work fine now. But your codes still fail to pass these tests, please double check your codes and re-run the failed tests untill all of them are passed.

@char-1ee char-1ee force-pushed the firecracker-snapshot-upf branch 3 times, most recently from 23d83a1 to 03f0a07 Compare November 27, 2023 18:59
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add the recompiled firecracker-container binaries
  • use gomft
  • other comments

ctriface/iface.go Outdated Show resolved Hide resolved
ctriface/iface.go Outdated Show resolved Hide resolved
ctriface/iface_test.go Show resolved Hide resolved
@@ -39,7 +39,7 @@ replace (
)

replace (
github.com/firecracker-microvm/firecracker-containerd => github.com/vhive-serverless/firecracker-containerd v0.0.0-20230912063208-ad6383f05e45
github.com/firecracker-microvm/firecracker-containerd => github.com/char-1ee/firecracker-containerd v0.0.0-20231018191519-49cac5eea134
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update our fork after testing

scripts/github_runner/Dockerfile.github_runner Outdated Show resolved Hide resolved
@char-1ee char-1ee force-pushed the firecracker-snapshot-upf branch 4 times, most recently from 67a757a to 95e511d Compare December 12, 2023 10:53
Signed-off-by: char-1ee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants