Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files for image-rotate benchmark #1003

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Files for image-rotate benchmark #1003

merged 2 commits into from
Jul 23, 2024

Conversation

KarthikL1729
Copy link
Collaborator

@KarthikL1729 KarthikL1729 commented Jul 19, 2024

Tested locally with docker-compose. Added profiling to relay.

@KarthikL1729 KarthikL1729 force-pushed the image-rotate branch 2 times, most recently from b7110ab to 33445c8 Compare July 19, 2024 13:05
tools/relay/server Outdated Show resolved Hide resolved
tools/relay/server.go Outdated Show resolved Hide resolved
@KarthikL1729 KarthikL1729 force-pushed the image-rotate branch 11 times, most recently from 9ef4819 to 4ebcce6 Compare July 22, 2024 10:31
Copy link
Contributor

@dhschall dhschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. Just some minor things. Also if you could use git lfs to track the image files that would be great

.github/workflows/e2e-image-rotate.yml Outdated Show resolved Hide resolved
benchmarks/image-rotate/go/server.go Outdated Show resolved Hide resolved
benchmarks/image-rotate/init/init-database.go Outdated Show resolved Hide resolved
benchmarks/image-rotate/python/server.py Outdated Show resolved Hide resolved
benchmarks/image-rotate/images/img1.jpg Outdated Show resolved Hide resolved
Lakshman added 2 commits July 23, 2024 01:20
Copy link
Contributor

@dhschall dhschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @KarthikL1729 !

@dhschall dhschall merged commit bafa568 into main Jul 23, 2024
38 of 45 checks passed
@dhschall dhschall deleted the image-rotate branch July 23, 2024 11:27
@dhschall dhschall restored the image-rotate branch July 23, 2024 11:27
@dhschall dhschall deleted the image-rotate branch July 23, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants