-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MHPY-10 documentation #8
base: main
Are you sure you want to change the base?
Conversation
19c0071
to
54a7d72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is - or will be - a public library, I would definitely include the README as it was before as well: the "Usage" and "Synopsis" sections provide a useful introduction to the library.
The title of the README should best remain "MediaHaven Python Library"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Maarten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version of handsdown
was used to generate the docs?
It might be advised to:
- Add the
handsdown
library in therequirements-dev.txt
file. - Add some information about how to generate the docs in the README.
@@ -0,0 +1,6 @@ | |||
#!/bin/bash | |||
|
|||
handsdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handsdown | |
handsdown mediahaven |
Only create docs for the files in the mediahaven
folder. Without it, it also tried to generate docs for certain packages in my venv
folder.
#!/bin/bash | ||
|
||
handsdown | ||
mv docs/README.md . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves a generated README.md file to the root folder, essentially overwriting the existing README file. This is not desired.
sed -i 's/mediahaven\//docs\/mediahaven\//g' README.md | ||
find docs/ -type f -exec sed -i 's/\.\.\/README\.md/..\/..\/README.md/g' {} \; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not moving the README file makes these replace actions unnecessary I assume?
Note: the docs needs to be remade because of merge of |
Documentation generated with https://vemel.github.io/handsdown/.